[master/rhel7] Add more details to iso device selector (#971290)

Chris Lumens clumens at redhat.com
Mon Sep 9 18:08:03 UTC 2013


> diff --git a/pyanaconda/ui/gui/spokes/source.py b/pyanaconda/ui/gui/spokes/source.py
> index 8dd8ba2..e8fb3c5 100644
> --- a/pyanaconda/ui/gui/spokes/source.py
> +++ b/pyanaconda/ui/gui/spokes/source.py
> @@ -625,7 +625,14 @@ class SourceSpoke(NormalSpoke):
>          active = 0
>          idx = 0
>          for dev in potentialHdisoSources(self.storage.devicetree):
> -            store.append([dev, "%s (%s MB)" % (self._sanitize_model(dev.disk.model), int(dev.size))])
> +            # path model size format type uuid of format
> +            dev_info = { "model" : self._sanitize_model(dev.disk.model),
> +                         "path"  : dev.path,
> +                         "size"  : dev.size,
> +                         "format": dev.format.name or "",
> +                         "label" : dev.format.label or dev.format.uuid or ""
> +                       }
> +            store.append([dev, "%(model)s %(path)s (%(size)s MB) %(format)s %(label)s" % dev_info])
>              if self.data.method.method == "harddrive" and dev.name == self.data.method.partition:
>                  active = idx
>              added = True

I'd prefer some separators like dashes or whatever between the fields.
It kind of looks like a run-on sentence now.

- Chris


More information about the anaconda-patches mailing list