[PATCH] Fix lightbox signal handling (#1000927)
Vratislav Podzimek
vpodzime at redhat.com
Mon Sep 9 07:47:59 UTC 2013
On Fri, 2013-09-06 at 17:34 -0400, David Shea wrote:
> As part of this, I also:
> - Removed anaconda_lb_destroy, since it didn't do anything useful that
> a signal handler couldn't
> - Bumped the soversion of libAnacondaWidgets since this removes a
> public interface
> - Switched to using destroy handlers to cleanup the lightbox
> references that are set in other objects
> - Renamed some variables and added some comments to hopefully make it
> easier to tell what's actually going on
> ---
> pyanaconda/ui/gui/tools/run-spoke.py | 2 +-
> pyanaconda/ui/gui/utils.py | 2 +-
> scripts/makeupdates | 2 +-
> widgets/src/Makefile.am | 2 +-
> widgets/src/lightbox.c | 290 ++++++++++++++++++++++++-----------
> widgets/src/lightbox.h | 1 -
> 6 files changed, 206 insertions(+), 93 deletions(-)
Looking at the amount of changes I wonder whether it wouldn't be better
to make lightbox a proper widget (object) with construction, instance
attributes, destruction and so on.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list