[PATCH 4/6] Pass logging string format variables as parameters

David Shea dshea at redhat.com
Sun Sep 8 16:33:21 UTC 2013


---
 pyanaconda/network.py               | 2 +-
 pyanaconda/packaging/yumpayload.py  | 2 +-
 pyanaconda/ui/gui/spokes/welcome.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pyanaconda/network.py b/pyanaconda/network.py
index 3c7f638..692d655 100644
--- a/pyanaconda/network.py
+++ b/pyanaconda/network.py
@@ -433,7 +433,7 @@ def get_ks_network_data(devname, ifcfg_suffix=None):
     try:
         device_cfg.loadIfcfgFile()
     except IOError as e:
-        log.debug("get_ks_network_data %s: %s" % (ifcfg_suffix, e))
+        log.debug("get_ks_network_data %s: %s", ifcfg_suffix, e)
         return None
     retval = kickstartNetworkData(ifcfg=device_cfg)
     if retval and devname in nm.nm_activated_devices():
diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
index 5ca770a..142678c 100644
--- a/pyanaconda/packaging/yumpayload.py
+++ b/pyanaconda/packaging/yumpayload.py
@@ -1230,7 +1230,7 @@ reposdir=%s
             # check dependencies
             log.info("checking dependencies")
             (code, msgs) = self._yum.buildTransaction(unfinished_transactions_check=False)
-            log.debug("buildTransaction = (%s, %s)" % (code, msgs))
+            log.debug("buildTransaction = (%s, %s)", code, msgs)
             self._removeTxSaveFile()
             if code == 0:
                 # empty transaction?
diff --git a/pyanaconda/ui/gui/spokes/welcome.py b/pyanaconda/ui/gui/spokes/welcome.py
index 219c344..68fd007 100644
--- a/pyanaconda/ui/gui/spokes/welcome.py
+++ b/pyanaconda/ui/gui/spokes/welcome.py
@@ -116,7 +116,7 @@ class WelcomeLanguageSpoke(LangLocaleHandler, StandaloneSpoke):
                 # does not support typing ASCII chars, append the 'us' layout
                 new_layouts.append("us")
         else:
-            log.error("Failed to get layout for chosen locale '%s'" % locale)
+            log.error("Failed to get layout for chosen locale '%s'", locale)
             new_layouts = ["us"]
 
         self.data.keyboard.x_layouts = new_layouts
-- 
1.8.3.1



More information about the anaconda-patches mailing list