[master][PATCH] Remove magic from the passphrase dialog

Brian C. Lane bcl at redhat.com
Fri Sep 6 18:18:05 UTC 2013


On Fri, Sep 06, 2013 at 03:35:28PM +0200, Vratislav Podzimek wrote:
> Playing with sensitivity and jumping between widgets based on equality of the
> password and confirmation entries is confusing and may cause problems. The
> confirmation entry cannot be clicked when the password entry is being eddited,
> only TAB works for switching into it. And jumping to the save button when the
> confirmation entry equals the password entry may lead in an incomplete password
> entered and "confirmed".
> 
> Hitting ENTER in one of the entries may click the Save button if both entries
> have the same string.

Looks like this solves 921948. I wasn't able to reproduce it at the time
IIRC and had let it sit.

>      def on_confirm_changed(self, entry):
>          if not self._save_button.get_sensitive() and \
>             entry.get_text() == self._passphrase_entry.get_text():
> -            self._save_button.set_sensitive(True)
> -            self._save_button.grab_focus()
> -            self._save_button.grab_default()
>              self._set_entry_icon(entry, "", "")
> +            self._save_button.set_sensitive(True)

I think this should mirror the password changed behavior and set
sensitive to False when it doesn't match. eg. If I set matching
passwords, then type more into the top entry the button goes
insensitive. But if I add more to the confirm entry it stays sensitive
until I switch to the top or hit tab.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130906/a2705290/attachment.sig>


More information about the anaconda-patches mailing list