[initial-setup][PATCH] Read /etc/system-release to get product title (#1000426)

Vratislav Podzimek vpodzime at redhat.com
Thu Sep 5 07:02:34 UTC 2013


On Wed, 2013-09-04 at 18:17 -0500, Dennis Gilmore wrote:
> El Tue, 03 Sep 2013 16:16:33 +0200
> Vratislav Podzimek <vpodzime at redhat.com> escribió:
> > On Tue, 2013-09-03 at 07:34 -0500, Dennis Gilmore wrote:
> > > On Wed, 28 Aug 2013 12:13:40 +0200
> > > Vratislav Podzimek <vpodzime at redhat.com> wrote:
> > > 
> > > > The /etc/system-release file contains a release name that we want
> > > > to display in the UI.
> > > > 
> > > > For GUI we can use just the product title because the string
> > > > "INITIAL SETUP" is shown in the top-left corner. For TUI we
> > > > should inform user that this is an initial setup of the system.
> > > > 
> > > > Also rename the hub files not to clash with the the Python package
> > > > name.
> > > 
> > > you really should be reading /etc/os-release not /etc/system-release
> > Any reference to some documentation/guidelines? I have no problem
> > changing it, but I just wonder what is the difference and which one of
> > those two symlinks is preferred.
> > 
> > Thanks,
> > 
> 
> /etc/os-release is a completely different file, It is part of the
> systemd specifications. 
> 
> ls -lah /etc/*release
> -rw-r--r--. 1 root root  25 ago 30 15:44 /etc/fedora-release
> -rw-r--r--. 1 root root 281 ago 30 15:44 /etc/os-release
> lrwxrwxrwx. 1 root root  14 sep  1 11:36 /etc/redhat-release -> fedora-release
> lrwxrwxrwx. 1 root root  14 sep  1 11:36 /etc/system-release -> fedora-release
> 
> 
> its what ABRT and others are using for distro definitions, and is
> distro agnostic. where system-release fedora-release and redhat-release
> are specific files to Red Hat and Fedora. I have not yet been asked to
> remove them but i honestly suspect that at some time in the future I
> will be asked to do so. leaving only /etc/os-release
Thanks for the additional info, I'll change the code to read
the /etc/os-release file.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list