[PATCH 1/2] Clean up code for input handling in TUI spokes.

Vratislav Podzimek vpodzime at redhat.com
Wed Sep 4 05:42:28 UTC 2013


>      @property
> -    def completed(self):
> -        return True # We're always complete
> +        def completed(self):
> +            return True # We're always complete
I believe these two lines shouldn't be indented more. Other than that I
agree with Brian that we should use comparisons instead of using range.
And if we need to use range somewhere, it should be replaced with
xrange.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list