[master] Languages and locales related patches

Radek Vykydal rvykydal at redhat.com
Tue Sep 3 12:47:13 UTC 2013


The patchset looks good to me with some minor comments.

I like the UI, only the boldness of langs selected in langsupport
spoke doesn't seem to highlight the items very much in the video.

On 08/30/2013 11:15 AM, Vratislav Podzimek wrote:
> These patches do mainly three things:
>
> 1) Rework the Welcome spoke and Langsupport spoke to work with all locales
> available instead of few locales we think are best for languages we have
> translations for.
>
> 2) Remove the cryptic checkbutton for setting only the language-default keyboard
> layout instead of a combination with the 'us' layout. Having the layout
> indicator now, we may set the language-default layout as the only one and switch
> to it from the default 'us' layout (active on the Welcome spoke) automatically.
> Exceptions are languages the default layout of which don't support typing ASCII
> characters. For those layouts we should append 'us' to the list of activated
> layouts and set up layout switching automatically.
>
> 3) Get rid of the expand_langs() function and it's usage resulting in
> highly-probably nondeterministic results.
>
> I've recorded a video preview [1] demonstrating the new look and behaviour.
>
> [1] http://vpodzime.fedorapeople.org/locales_changes.webm
>
> Altough there are many lines of code added by those patches, the overall user
> experience should be much better and they resolve a lot of bugs and complaints.
> And I want to come up with a patch dealing with a lot of code duplicated in
> Welcome and Langsupport spokes' code that should result in many lines removed.
> However, I'd like to see those 7 patches landing in the Fedora 20 asap because
> it is quite a significant change for users.
>
> Vratislav Podzimek (7):
>    Remove an unused argument of get_available_translations
>    Allow seting up locale without modifying ksdata
>    Remove the cryptic "language-default keyboard" checkbutton
>    Improve import in GUI utils a bit
>    Rework the Welcome spoke to allow users choose from all locales
>    Rework the Langsupport spoke to work with all locales
>    Get rid of the non-deterministic expand_langs and its usage
>
>   pyanaconda/localization.py                  | 156 ++++++++-----
>   pyanaconda/packaging/yumpayload.py          |   9 +-
>   pyanaconda/ui/gui/hubs/progress.py          |  53 +++--
>   pyanaconda/ui/gui/spokes/langsupport.glade  | 167 ++++++++++----
>   pyanaconda/ui/gui/spokes/langsupport.py     | 244 +++++++++++---------
>   pyanaconda/ui/gui/spokes/welcome.glade      | 336 ++++++++++++++--------------
>   pyanaconda/ui/gui/spokes/welcome.py         | 192 +++++++++-------
>   pyanaconda/ui/gui/utils.py                  |  45 +++-
>   tests/pyanaconda_tests/localization_test.py |  61 ++++-
>   9 files changed, 772 insertions(+), 491 deletions(-)
>



More information about the anaconda-patches mailing list