[PATCH] Re-saved every glade file with glade-3.16.0

David Shea dshea at redhat.com
Thu Oct 31 18:40:48 UTC 2013


On 10/30/2013 08:56 AM, Vratislav Podzimek wrote:
> On Wed, 2013-10-23 at 11:27 -0400, David Shea wrote:
>> On 10/21/2013 04:37 PM, Chris Lumens wrote:
>>>> @@ -33,6 +38,7 @@
>>>>                <property name="can_focus">False</property>
>>>>                <property name="yalign">0</property>
>>>>                <property name="xscale">0.5</property>
>>>> +            <property name="yscale">0.5</property>
>>>>                <child internal-child="action_area">
>>>>                  <object class="GtkBox" id="progressWindow-actionArea">
>>>>                    <property name="can_focus">False</property>
>>> The ones that change x/yscale and x/yalign worry me.  Does everything
>>> still look right?
>> Sure doesn't: http://dshea.fedorapeople.org/glade-oops.png
>>
>> I'm not sure why it set that property, and, frustratingly, if I change
>> the yscale to the default (1.0) and re-save, glade removes the property.
>> So remove it I shall.
> Isn't this a bug in our code in widgets/src/glade-adaptor.c in the
> following lines:
>
>      if (ANACONDA_IS_HUB_WINDOW(object)) {
>          glade_widget_property_set(alignment_widget, "xalign", 0.5);
>          glade_widget_property_set(alignment_widget, "yalign", 0.0);
>          glade_widget_property_set(alignment_widget, "xscale", 0.5);
>          glade_widget_property_set(alignment_widget, "yscale", 0.5);
>      } else {
>          glade_widget_property_set(alignment_widget, "xalign", 0.5);
>          glade_widget_property_set(alignment_widget, "yalign", 0.0);
>          glade_widget_property_set(alignment_widget, "xscale", 1.0);
>          glade_widget_property_set(alignment_widget, "yscale", 1.0);
>      }
>
> ?
>
Yeah probably. The summary hub doesn't set yscale either, so might as 
well set it back to the default.


More information about the anaconda-patches mailing list