[f20-branch][PATCH] If an invalid size is given, reset the entry to the old value (#1021511)
Chris Lumens
clumens at redhat.com
Mon Oct 28 14:27:20 UTC 2013
It looks like you've got the wrong bug number in your commit message.
> I user gives us e.g. a too small size for a mountpoint, we should reset the
> entry to the old value. That gives a feedback that it was not possible to do the
> change.
I wonder if it's enough to just reset the value. Will the user know
what that means, or will they think it's a bug that anaconda's not
taking the value given?
> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
> index 48e58e7..6131048 100644
> --- a/pyanaconda/ui/gui/spokes/custom.py
> +++ b/pyanaconda/ui/gui/spokes/custom.py
> @@ -1454,6 +1454,9 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
> self.set_warning(_("Device resize request failed. "
> "Click for details."))
> self.window.show_all()
> + except ValueError as e:
> + log.error("failed to resize device %s to %s: %s" % (device.name, size, e))
pylint will complain about using % instead of , in the log call.
- Chris
More information about the anaconda-patches
mailing list