[blivet][master/rhel7-branch] If installing on s390x, check to make sure /boot is on single PV. (#873135, #885011)

David Lehman dlehman at redhat.com
Thu Oct 24 17:42:03 UTC 2013


On Thu, 2013-10-24 at 13:23 -0400, Samantha N. Bueno wrote:
> Resolves: rhbz#873135
> Resolves: rhbz#885011
> ---
>  blivet/__init__.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/blivet/__init__.py b/blivet/__init__.py
> index 9420c50..83d3507 100644
> --- a/blivet/__init__.py
> +++ b/blivet/__init__.py
> @@ -1458,6 +1458,12 @@ class Blivet(object):
>          swaps = self.fsset.swapDevices
>          try:
>              boot = self.bootDevice
> +            # /boot must be on a single PV if installing on s390x, since ZIPL
> +            # can't handle anything more complex
> +            if arch.isS390() and boot.type == "lvmlv":
> +                if not boot.singlePV:
> +                    errors.append(_("This platform requires /boot on a single "
> +                                    "physical volume or disk."))
>          except (DeviceError, AttributeError):
>              boot = None
>  

There is similar code in sanityCheck for root on s390. Perhaps this
should instead be handled in the bootloader is_valid_stage2_device for
the S390 bootloader class to abstract the /boot -v- / piece and have the
code to check and issue an error only in one place.





More information about the anaconda-patches mailing list