[PATCH] Set default value for bootloader location field to mbr.

mulhern amulhern at redhat.com
Thu Oct 24 12:11:50 UTC 2013


Related: rhbz#916529

The value of "mbr" is the default value that anaconda uses for an interactive
install. This value is set by the data/interactive-installs.ks file in
anaconda. This value is now the default for any install but can be overridden
by a kickstart file.

The value is set in the constructor because that was probably the intention. All
other values set in the constructor correspond to the defaults set in the
corresponding parser. Previously every other field got the default regardless
of whether or not a bootloader line was actually parsed. Now, location
behaves that way, too.

Need to remove the corresponding line from data/interactive-install.ks because
this change makes it redundant.

Signed-off-by: mulhern <amulhern at redhat.com>
---
 pykickstart/commands/bootloader.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pykickstart/commands/bootloader.py b/pykickstart/commands/bootloader.py
index 32035cf..55e0053 100644
--- a/pykickstart/commands/bootloader.py
+++ b/pykickstart/commands/bootloader.py
@@ -32,7 +32,7 @@ class FC3_Bootloader(KickstartCommand):
         self.appendLine = kwargs.get("appendLine", "")
         self.forceLBA = kwargs.get("forceLBA", False)
         self.linear = kwargs.get("linear", True)
-        self.location = kwargs.get("location", "")
+        self.location = kwargs.get("location", "mbr")
         self.md5pass = kwargs.get("md5pass", "")
         self.password = kwargs.get("password", "")
         self.upgrade = kwargs.get("upgrade", False)
-- 
1.8.3.1



More information about the anaconda-patches mailing list