[master/f20/rhel7] remove signal disconnect (#996899)

Brian C. Lane bcl at redhat.com
Tue Oct 22 21:47:56 UTC 2013


On Tue, Oct 22, 2013 at 05:28:35PM -0400, David Shea wrote:
> On 10/22/2013 05:05 PM, Brian C. Lane wrote:
> >From: "Brian C. Lane" <bcl at redhat.com>
> >
> >The widget is getting destroyed anyway, so let that handle the
> >disconnect.
> >
> >Resolves: rhbz#996899
> >---
> >  widgets/src/BaseWindow.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> >diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c
> >index d587d6e..0fcf4e8 100644
> >--- a/widgets/src/BaseWindow.c
> >+++ b/widgets/src/BaseWindow.c
> >@@ -562,8 +562,6 @@ void anaconda_base_window_clear_info(AnacondaBaseWindow *win) {
> >      if (!win->priv->info_shown)
> >          return;
> >-    g_object_disconnect(win->priv->info_bar, "button-release-event", NULL);
> >-
> >      gtk_widget_hide(win->priv->info_bar);
> >      gtk_widget_destroy(win->priv->info_bar);
> >      gtk_widget_destroy(win->priv->event_box);
> Ack. And to follow up the question in IRC, I confirmed that all of
> the signals are removed on the last g_object_unref.
> 
> For f20+master, revert e96dec3d before applying to clean up the
> stuff Vratislav added to switch to g_signal_handler_disconnect on
> the event_box (which is also cleaned up when destroyed).

Will do. Thanks for the help.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list