[PATCH 2/2] fix swaps added to fstab for noformat

Vratislav Podzimek vpodzime at redhat.com
Mon Oct 21 09:26:36 UTC 2013


On Fri, 2013-10-18 at 15:44 -0400, Gene Czarcinski wrote:
> There are three and not two possible situations for a swap:
> a new partition/logical volume, reformat an existing partition or
> logical volume and do not format (--noformat) a partition
> or logical volume.
> ---
>  pyanaconda/kickstart.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> index 4624fce..f7dadb4 100644
> --- a/pyanaconda/kickstart.py
> +++ b/pyanaconda/kickstart.py
> @@ -742,6 +742,8 @@ class LogVolData(commands.logvol.F20_LogVolData):
>  
>              dev.format.mountpoint = self.mountpoint
>              dev.format.mountopts = self.fsopts
> +            if ty == "swap":
> +                storage.addFstabSwap(dev)
>              return
>  
>          # Make sure this LV name is not already used in the requested VG.
> @@ -1000,6 +1002,8 @@ class PartitionData(commands.partition.F18_PartData):
>  
>              dev.format.mountpoint = self.mountpoint
>              dev.format.mountopts = self.fsopts
> +            if ty == "swap":
> +                storage.addFstabSwap(dev)
>              return
>  
>          # Now get a format to hold a lot of these extra values.
This one looks good to me, good catch, thanks! I'll push this one and
leave the other one for Dave to look at it.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list