[master/f20 0/4] A simple checkbox fix. not. (#1016801)

Brian C. Lane bcl at redhat.com
Wed Oct 16 20:30:46 UTC 2013


From: "Brian C. Lane" <bcl at redhat.com>

You would expect a checkbox that doesn't want to behave would be a simple fix,
wouldn't you? Nope.

The first patch fixes up the pykickstart method handling so that get and set
work on the same thing (handler.url) when method.method = None

With that fixed the fallback to closest mirror can be fixed. If we set it to
url then we have no way to tell the difference between a url with no text or a
closest mirror selection. This causes it to think it changed every time, so the
metadata is fetched you exited the source spoke. The side-effect of this is to
re-enable the updates repo when things are reset for the metadata download.

With that in place now we have to fix up the checkbox so that it always behaves
correctly. Instead of scattering that all over the place do it in one spot and
just call it when needed. Also take into account the state of the updates repo,
not only closest mirror being selected.

Which leads to a simple fix. Once the proxy change has triggered change, reset
it so that it doesn't happen every time you leave the spoke.

Brian C. Lane (3):
  Fall back to closest mirror in source (#1016801)
  Setup No Update checkbox correctly (#1016801)
  Reset _proxyChange when a change is triggered

 pyanaconda/ui/gui/spokes/source.py | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

-- 
1.8.3.1



More information about the anaconda-patches mailing list