[PATCH 5/7] Replace placeholders with the strings from python

David Shea dshea at redhat.com
Wed Oct 16 13:40:54 UTC 2013


On 10/16/2013 03:50 AM, Vratislav Podzimek wrote:
>> >diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
>> >index 43b1bf6..31f6b1f 100644
>> >--- a/pyanaconda/ui/gui/spokes/storage.py
>> >+++ b/pyanaconda/ui/gui/spokes/storage.py
>> >@@ -123,34 +123,33 @@ class InstallOptions1Dialog(GUIObject):
>> >  
>> >          options_label = self.builder.get_object("options1_label")
>> >  
>> >-        options_text = _("You have <b>%(freeSpace)s</b> of free space, which is "
>> >-                         "enough to install %(productName)s.  What would you "
>> >-                         "like to do?") % {"freeSpace": disk_free, "productName": productName}
>> >+        options_text = _("<span font-desc=\"Cantarell 11\">You have <b>%(freeSpace)s</b> "
>> >+                         "of free space, which is enough to install %(productName)s.  "
>> >+                         "What would you like to do?</span>") %\
>> >+                         {"freeSpace": disk_free, "productName": productName}
> I think we should set attributes properly, not by placing tags in
> translatable strings that are translated. This would break translations
> now and every time we change the markup. But maybe that should go in a
> separate patch fixing it in a lot more places.
Related to that, we need to be using GLib.markup_escape_text any time we 
generate a markup string like this.


More information about the anaconda-patches mailing list