[master] Found some more keyboard accelerator problems to fix

Vratislav Podzimek vpodzime at redhat.com
Wed Oct 16 07:51:33 UTC 2013


On Tue, 2013-10-15 at 14:15 -0400, David Shea wrote:
> The first patch makes the accelerator exception comments explicit as far as
> what node is causing the exception. The previous exception check just marked
> a conflict as an exception without context, so it was possible to miss problems
> if accelerators changed.
> 
> The second patch fixes the handling of translations of plural strings in
> keyboard accelerators.
> 
> The third patch adds checks for strings that have use_underline set but no
> accelerator defined. 4-7 fix the problems that this patch found.
Apart from the comments on the PATCH 5/7 these all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list