[PATCH blivet/master] Add initial 64-bit ARM (aarch64) support.

David Marlin dmarlin at redhat.com
Mon Oct 14 21:21:10 UTC 2013


Brian C. Lane wrote:
> On Mon, Oct 14, 2013 at 11:15:42AM -0500, d.marlin wrote:
>> From: "d.marlin" <dmarlin at redhat.com>
>>
>> Signed-off-by: David A. Marlin <dmarlin at redhat.com>
>> ---
>>  blivet/arch.py     | 10 ++++++++++
>>  blivet/platform.py | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 38 insertions(+)
> 
>> +class AARCH64(Platform):
>> +    _boot_stage1_device_types = ["disk"]
>> +    _boot_mbr_description = N_("Master Boot Record")
>> +    _boot_descriptions = {"disk": _boot_mbr_description,
>> +                          "partition": Platform._boot_partition_description}
>> +
>> +    _disklabel_types = ["msdos", "gpt"]
>> +    _non_linux_format_types = ["vfat", "ntfs"]
>> +
>> +    def __init__(self):
>> +        super(AARCH64, self).__init__()
>> +
>> +    def setDefaultPartitioning(self):
>> +        """Return the default platform-specific partitioning information."""
>> +        ret = Platform.setDefaultPartitioning(self)
>> +        return ret
> 
> No need to override __init__ and setDefaultPartitioning here, they're
> just doing the same thing as the superclass.

Ok, I was just mimicking what "class X86(Platform)" was doing for 
__init__.  I assumed that was included to use the "gpt" in 
_disklabel_types.  Is that not the case?

I will remove the setDefaultPartitioning.  Does the same apply to weight?

>> +
>> +    def weight(self, fstype=None, mountpoint=None):
>> +        score = Platform.weight(self, fstype=fstype, mountpoint=mountpoint)
>> +        if score:
>> +            return score
>> +        elif mountpoint == "/boot":
>> +            return 2000
>> +        else:
>> +            return 0
> 
> Is AARCH64 is different enough from other ARMs that we don't want to
> subclass ARM and use isARM()?

Yes, AARCH64 (64-bit ARM) is quite different from 32-bit ARM, and from 
an installation setup perspective, will be closer to X86_64 than 32-bit 
ARM platforms.


d.marlin
============

> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list