[master][PATCH] MountpointSelector is a widget, set its property properly (#1013612)

David Shea dshea at redhat.com
Mon Oct 14 14:30:50 UTC 2013


On 10/14/2013 04:06 AM, Vratislav Podzimek wrote:
> On Fri, 2013-10-11 at 13:20 -0700, Brian C. Lane wrote:
>> On Fri, Oct 11, 2013 at 01:10:41PM -0700, Brian C. Lane wrote:
>>> On Thu, Oct 10, 2013 at 04:37:20PM +0200, Vratislav Podzimek wrote:
>>>> Setting 'size' attribute of our Python wrapping code is not the same as settings
>>>> widget's property.
>>>>
>>>> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
>>>> ---
>>>>   widgets/python/AnacondaWidgets.py | 8 ++++++++
>>>>   1 file changed, 8 insertions(+)
>>> Pushed.
>> Or not. pylint is complaining:
>>
>> ************* Module
>> ./tests/pylint/../../widgets/python/AnacondaWidgets.py
>> I0011: 88,0: : Locally disabling W0232
>> E1101: 48,15: MountpointSelector.size: Instance of 'MountpointSelector' has no 'get_property' member
>>
>> I'm not sure why that's a problem when it doesn't complain about
>> set_property.
> That seems to me like a bug in pylint because the code works and every
> GObject has the 'get_property' method [1]. Shall I add a comment that
> will disable E1101 locally?
>
> [1]
> https://developer.gnome.org/gobject/stable/gobject-The-Base-Object-Type.html#g-object-get-property
>
I'd be ok with that. I was looking at this on Friday, and I couldn't 
find any reason for pylint to legitimately complain. It's just baffling 
that it would complain about get_property but not set_property, since 
both of those methods are coming from the GObject class.


More information about the anaconda-patches mailing list