[PATCH rhel6-branch] Support bonding in %pre section (#971961)

Brian C. Lane bcl at redhat.com
Fri Oct 11 00:23:24 UTC 2013


On Tue, Oct 08, 2013 at 03:08:21PM +0200, Radek Vykydal wrote:
> On 10/04/2013 06:53 PM, Brian C. Lane wrote:
> >On Tue, Oct 01, 2013 at 12:12:46PM +0200, Radek Vykydal wrote:
> >>+
> >>+                        slavedev.set(("NM_CONTROLLED", "yes"))
> >>+                time.sleep(2)
> >Is this sleep really needed?
> 
> The reason for sleep is here:
> https://bugzilla.redhat.com/show_bug.cgi?id=971961#c2
> 
> I don't like using sleep but I considered it safer, given the sleep
> ocsurs only in case of activation of bond defined in %pre case.
> Nevertheless, I am sending v2 of the patch replacing sleep with
> polling state of devices.

Thanks for the explanation, I like the polling loop you added.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20131010/2c07b262/attachment.sig>


More information about the anaconda-patches mailing list