[master][PATCH] Install kernel-lpae if supported (#1013015)

David Shea dshea at redhat.com
Wed Oct 9 14:40:21 UTC 2013


On 10/09/2013 10:35 AM, Vratislav Podzimek wrote:
> On Wed, 2013-10-09 at 10:13 -0400, David Shea wrote:
>> On 10/09/2013 09:04 AM, Vratislav Podzimek wrote:
>>> As the bug suggests, we should install kernel-lpae package on devices that
>>> support it.
>>>
>>> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
>>> ---
>>>    pyanaconda/isys/__init__.py      | 8 ++++++++
>>>    pyanaconda/packaging/__init__.py | 3 +++
>>>    2 files changed, 11 insertions(+)
>>>
>>> diff --git a/pyanaconda/isys/__init__.py b/pyanaconda/isys/__init__.py
>>> index b785bc7..6a9db16 100644
>>> --- a/pyanaconda/isys/__init__.py
>>> +++ b/pyanaconda/isys/__init__.py
>>> @@ -109,6 +109,14 @@ def isPaeAvailable():
>>>    
>>>        return isPAE
>>>    
>>> +def isLpaeAvailable():
>>> +    with open("/proc/cpuinfo", "r") as fobj:
>>> +        for line in fobj:
>>> +            if line.startswith("Features") and "lpae" in line:
>>> +                return True
>>> +
>>> +    return False
>>> +
>>>
>> Should we split line on whitespace and look for lpae in the list?
>> This'll work for now, but I wonder how long before some new thing gets
>> called something like "xlpae" and has to be handled differently.
> Good point, I'll fix it locally. I guess it is okay otherwise?
>
Yeah, looks fine.


More information about the anaconda-patches mailing list