[pykickstart][PATCH] Add --remove-service option for the firewall command (#957809)
Martin Kolman
mkolman at redhat.com
Mon Oct 7 14:57:26 UTC 2013
On Mon, 2013-10-07 at 10:37 -0400, Chris Lumens wrote:
> > diff --git a/pykickstart/commands/firewall.py b/pykickstart/commands/firewall.py
> > index 664bea6..1384d63 100644
> > --- a/pykickstart/commands/firewall.py
> > +++ b/pykickstart/commands/firewall.py
> > @@ -191,3 +191,45 @@ class F14_Firewall(F10_Firewall):
> > op = F10_Firewall._getParser(self)
> > op.remove_option("--telnet")
> > return op
> > +
> > +class F20_Firewall(F14_Firewall):
> > + removedKeywords = F14_Firewall.removedKeywords
> > + removedAttrs = F14_Firewall.removedAttrs
> > +
> > + def _getParser(self):
> > + def remove_service_cb(option, opt_str, value, parser):
> > + # python2.4 does not support action="append_const" that we were
> > + # using for these options. Instead, we have to fake it by
> > + # appending whatever the option string is to the service list.
> > + # XXX: is this still relevant ?
>
> This breaks "make check".
Oh, right - but unfortunately I've already pushed it to master...
So I guess I can make a patch removing the Pylint-hated triple-X and
maybe also remove the whole python2.4 & append_const related comment ?
It doesn't look like very up-to-date/relevant.
>
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
More information about the anaconda-patches
mailing list