[blivet/rhel7 1/4] Let setUpBootLoader raise BootloaderError (#1015277)

Vratislav Podzimek vpodzime at redhat.com
Mon Oct 7 08:01:21 UTC 2013


On Thu, 2013-10-03 at 16:38 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> This allows callers to deal with bootloader errors.
> 
> Related: rhbz#1015277
> ---
>  blivet/__init__.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/blivet/__init__.py b/blivet/__init__.py
> index d15a0d0..083ce78 100644
> --- a/blivet/__init__.py
> +++ b/blivet/__init__.py
> @@ -1702,7 +1702,10 @@ class Blivet(object):
>          self.bootloader.set_disk_list(boot_disks)
>  
>      def setUpBootLoader(self):
> -        """ Propagate ksdata into BootLoader. """
> +        """ Propagate ksdata into BootLoader.
> +
> +            :raises: BootloaderError if stage1 setup fails
> +        """
I think that exceptions should be documented as:
:raises EXCEPTION: CONDITION

with the colon after the exception type. Or at least that makes sense to
me in context of the 'param' and 'type' fields.

Otherwise the patches look good to me, but I've not applied and tested
them yet.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list