[master] Fix some password handling issues

Vratislav Podzimek vpodzime at redhat.com
Thu Oct 3 08:06:31 UTC 2013


On Wed, 2013-10-02 at 17:22 -0400, David Shea wrote:
> The last round of password changes broke the pwquality message display (it
> turns out that the PWQError objects that pwquality raises have no named members
> because pwquality is kind of a turd), so this fixes that and a few other issues
> that had been bugging me.
> 
> Now the pwquality functions are only called once per password (in
> validatePassword), validatePassword only has one method for returning a string
> (return value instead of return value or exception (also: weak passwords are
> not exceptional, another thing I hate about libpwquality)), validatePassword
> doesn't re-read the pwquality config on every call, and the behavior of the
> password spoke matches the behavior of the user spoke.
These are all good ideas and the patches look good to me apart from the
few comments and questions.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list