[master] libtimezonemap updates

Vratislav Podzimek vpodzime at redhat.com
Thu Nov 28 08:39:47 UTC 2013


On Wed, 2013-11-27 at 12:19 -0500, David Shea wrote:
> I made a few tweaks to the libtimezonemap API to improve the handling of the
> Etc zones and incorporated them into the anaconda patch. The behavior now is to
> unset the pin and highlight the selected zone. The previous behavior was to
> unset the pin and highlight GMT.
> 
> You may notice as you select the Etc zones that the highlight seems backwards;
> e.g., Etc/GMT+5 selects the Eastern US and Canada and Colombia, in UTC-5. This
> is expected and it's because POSIX is freaking weird and defines + as hours
> west of Greenwich for some damn reason.
> 
> I didn't make any changes regarding not sending a location change signal when
> setting the location from a click, but I haven't noticed any problems from
> that. If it was from the Etc zones, it probably shouldn't be an issue, since
> the location-changed signal emitted by clear_location will have a NULL location
> pointer, and no change will be made to the combo boxes. If there was something
> else there, well, make your case.
These both look good to me. Big THANKS! I'll create a rawhide compose
soon and give the map some testing, but I think we can go no with these
patches and tweak some minor issues later, if there are some.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list