[PATCH grubby 2/4] grub: Fix a crash with kernel line without being preceded by title
Lubomir Rintel
lkundrak at v3.sk
Wed Nov 27 15:59:48 UTC 2013
Quite obviously this implies a broken configuration file where a lone kernel
line is found without ever seeing an entry start, resulting in a NULL
dereference attempt. Reproducible by running GRUB code against extlinux
configuration:
./grubby --grub -c test/extlinux.1 --default-kernel
grubby received SIGSEGV! Backtrace (6):
...
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
---
grubby.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grubby.c b/grubby.c
index 3de53b3..935edf1 100644
--- a/grubby.c
+++ b/grubby.c
@@ -1175,7 +1175,7 @@ static struct grubConfig * readConfig(const char * inName,
* lines came earlier in the template, make sure to use LT_HYPER
* instead of LT_KERNEL now
*/
- if (entry->multiboot)
+ if (entry && entry->multiboot)
line->type = LT_HYPER;
} else if (line->type == LT_MBMODULE) {
--
1.8.4.2
More information about the anaconda-patches
mailing list