[PATCH 1/3] Add support for adding zFCP devices in the GUI. (#994423)

David Shea dshea at redhat.com
Wed Nov 27 14:20:28 UTC 2013


On 11/27/2013 04:14 AM, Vratislav Podzimek wrote:
>> +
>> >+    def _device_valid(self, dev):
>> >+        """ Check whether the entered CCW entry is valid. """
>> >+        widget = self.builder.get_object("deviceEntry")
> All objects should be pulled only once, in the refresh method (or in a
> separate initialize method).
>
It should be in an initialize method, since refresh can also be called 
more than once. pylint can catch a lot of that kind of thing for you, 
which it reports as attributes defined outside of __init__ (we also 
allow attributes to be defined in initialize()).

pylint currently complains about _configureGrid, _cancelButton, 
_discoveryError, _startButton, _zfcpNotebook, _okButton, _deviceEntry 
and _conditionNotebook. Most of those are currently defined in refresh().


More information about the anaconda-patches mailing list