[master][rhel7-branch] Some advanced storage spoke patches, mostly s390x-related

Vratislav Podzimek vpodzime at redhat.com
Wed Nov 27 09:31:15 UTC 2013


On Tue, 2013-11-26 at 14:41 -0500, Samantha N. Bueno wrote:
> First just adds the ability for users to manually add zFCP devices
> from the advanced storage spoke. Following this, it should no longer be
> necessary to specify a zFCP device in a parm file. Celebrate.
> 
> Second breathes life into the lifeless skeleton of a z-panel that once
> was. I'm having some residual issues on this one and decided to post it
> for review anyway--the issues are minor and maybe another pair of eyes
> can help.
> Filtering devices by CCW (device id), LUN, and WWPN won't work for some
> reason. If I enter a LUN, this should occur:
>     self._lunEntry = self.builder.get_object("zLUNEntry")
>     ....
>     self._lunEntry.get_text()
> However, the text is always stored in one of the other two entries
> (zCCWEntry or zWWPNEntry). This behavior occurs with all three of the
> entries. Not sure what's going on there.
That's weird, but maybe you could drop the GtkNotebook here and have
just one entry and filtering based on the combo selection.

> 
> Also, the WWPN column in the treeview should be displaying the WWPN
> obviously, except....it isn't. Having a bit of trouble figuring out how
> to make this show up.
This is weird as well. Are you sure you have the right column numbers
used in the renderers? And is the data actually present in the store?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list