[master][rhel7-branch] Some advanced storage spoke patches, mostly s390x-related

Vratislav Podzimek vpodzime at redhat.com
Wed Nov 27 07:49:35 UTC 2013


On Tue, 2013-11-26 at 14:41 -0500, Samantha N. Bueno wrote:
> First just adds the ability for users to manually add zFCP devices
> from the advanced storage spoke. Following this, it should no longer be
> necessary to specify a zFCP device in a parm file. Celebrate.
> 
> Second breathes life into the lifeless skeleton of a z-panel that once
> was. I'm having some residual issues on this one and decided to post it
> for review anyway--the issues are minor and maybe another pair of eyes
> can help.
> Filtering devices by CCW (device id), LUN, and WWPN won't work for some
> reason. If I enter a LUN, this should occur:
>     self._lunEntry = self.builder.get_object("zLUNEntry")
>     ....
>     self._lunEntry.get_text()
> However, the text is always stored in one of the other two entries
> (zCCWEntry or zWWPNEntry). This behavior occurs with all three of the
> entries. Not sure what's going on there.
> 
> Also, the WWPN column in the treeview should be displaying the WWPN
> obviously, except....it isn't. Having a bit of trouble figuring out how
> to make this show up.
> 
> Third patch fixes an issue where searching by LUN in the advanced
> storage spoke failed.
> 
> Lastly, here's a screencast of the patches in action:
> http://sbueno.fedorapeople.org/s390x-gui-patches.webm
> If you want to have a poke yourself, I'm glad to give access to my s390x
> guest.
Just a minor comment on the GUI layout before I take a look at the
patches. I think the filtering should work the same as we do filtering
in other places -- i.e. dynamically without the Find button and with the
Clear button replaced by the entry secondary icon.

Otherwise the GUI looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list