[blivet 00/13] Refactor abstract RAID concept into a separate module

Anne Mulhern amulhern at redhat.com
Tue Nov 26 23:47:08 UTC 2013





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Tuesday, November 26, 2013 2:58:25 PM
> Subject: Re: [blivet 00/13] Refactor abstract RAID concept into a separate	module
> 
> 
> MDRaidArrayDevice.size cannot throw an exception for containers -- if
> that means you have to change the container class to return 0, that's
> okay.

Ok, I've changed size so that it catches the thrown exception and returns 0.
I'ld rather not have Container.get_size return 0.

> 
> Also, don't remove description -- it's present in every Device class and
> it is lightly used in the anaconda GUI.


It's back!

> 
> It is nice to see some of that code duplication corrected and to see so
> much of the calculation moved into devicelibs where it belongs.


Thanks!

- mulhern

> 
> David
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list