[blivet 05/13] Implement a RAID class hierarchy.

Anne Mulhern amulhern at redhat.com
Tue Nov 26 22:07:10 UTC 2013





----- Original Message -----
> From: "David Lehman" <dlehman at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Tuesday, November 26, 2013 2:49:55 PM
> Subject: Re: [blivet 05/13] Implement a RAID class hierarchy.
> 
> On Tue, 2013-11-26 at 13:47 -0500, mulhern wrote:
> > Signed-off-by: mulhern <amulhern at redhat.com>
> > ---
> >  blivet/devicelibs/raid.py          | 410
> >  +++++++++++++++++++++++++++++++++++++
> >  blivet/errors.py                   |   3 +
> >  tests/devicelibs_test/raid_test.py | 144 +++++++++++++
> >  3 files changed, 557 insertions(+)
> >  create mode 100644 blivet/devicelibs/raid.py
> >  create mode 100644 tests/devicelibs_test/raid_test.py
> > 
> > diff --git a/blivet/devicelibs/raid.py b/blivet/devicelibs/raid.py
> > new file mode 100644
> > index 0000000..f9ad1c1
> > --- /dev/null
> > +++ b/blivet/devicelibs/raid.py
> > @@ -0,0 +1,410 @@
> > +#
> > +# raid.py
> > +# representation of RAID levels
> > +#
> > +# Copyright (C) 2009  Red Hat, Inc.  All rights reserved.
> > +#
> > +# This program is free software; you can redistribute it and/or modify
> > +# it under the terms of the GNU General Public License as published by
> > +# the Free Software Foundation; either version 2 of the License, or
> > +# (at your option) any later version.
> > +#
> > +# This program is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> > +#
> > +# Author(s): Dave Lehman <dlehman at redhat.com>
> > +#            Anne Mulhern <amulhern at redhat.com>
> > +#
> > +
> > +import os
> > +
> > +from .. import util
> > +from ..errors import RaidError
> > +
> > +import gettext
> > +_ = lambda x: gettext.ldgettext("blivet", x)
> 
> dshea has changed how the above should look -- see commit
> bde4dcedd4f90e050. The rest looks good to me so far. Other things may
> appear to me as I work my way through the rest of the set.
> 

Yes. I don't actually translate here, so I should just get rid of that gettext stuff.
I can get rid of the os and util imports as well.

Fixed in working copy.

- mulhern

> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list