[master/f20 1/3] Remove threading from getBaseRepo handling (#1011555)

Chris Lumens clumens at redhat.com
Fri Nov 22 14:50:44 UTC 2013


> The original purpose of the getBaseRepo cache was to ensure that
> requests it weren't constantly sitting on the _yum_lock. This was

Assuming this is part of the commit message, you've got a typo or
missing word or something going on here.

> Any method decorated with @invalidate_br_cache ill re-validate the

It's invalidates_br_cache, and will.

> +    def getBaseRepo(self):
> +        """ Return the cached base repo id, if it is valid.
> +            Otherwise, re-validate it and return it.
> +
> +            This should result in minmal access to _yum_lock, especially
> +            since the methods that would invalidate the cached value also
> +            re-validate it after they have been run. These methods are
> +            decorated with @invalidate_br_cache

It's invalidates_br_cache here too.  Confusing since we have both
invalidate_ and invalidates_.

- Chris


More information about the anaconda-patches mailing list