[PATCH] Switch to libtimezonemap for the timezone map.

David Shea dshea at redhat.com
Fri Nov 15 13:34:15 UTC 2013


On 11/15/2013 03:11 AM, Vratislav Podzimek wrote:
> On Thu, 2013-11-14 at 13:41 -0500, David Shea wrote:
>> Remove all of our TimezoneMap widget code and paraphernalia in favor of
>> it being somebody else's problem.
> First of all, thanks a lot for working on this! A really great step in
> the right direction.
>
> I have just two comments:
> 1) We probably need 'Requires: libtimezonemap', I'm afraid rpmbuild
> cannot find it out from our Python imports. Or can it? If yes, we could
> drop libxklavier and libgnomekbd requires.
You're right, it didn't find it. I also didn't remove the tzmapdata from 
%files, so I'll do both of those.
>
> 2) Could you please have a look at commits
> 16685955504af2563930340400c66e04b6e21cd1 and
> 4a53beafb8a1a4264844d98445d385b5cd4cd9ea and make sure those things are
> covered somehow? I'm not saying that the solutions introduced with those
> commits are the right ones, but we need to cover those cases.
For the first one, I think I'd rather just have a check in 
on_city_changed. If the city didn't change, don't set the timezone.

For the second one, well, at least it doesn't crash. The timezonemap 
widget has its own timezone database, so it probably just doesn't know 
what to do with the Etc zones. I haven't heard back from upstream as far 
as why they switched to that over zone.tab (I'm guessing so that the map 
always represents a particular snapshot of the tz data and get out of 
sync like ours and GNOME's does), but I can take a look at that and 
patch something in. We'll just have to have a revision number in the 
Requires for a while.

http://dshea.fedorapeople.org/timezonemap.img has an updates image 
against Fedora Beta with libtimezonemap in it, if you want to try it out.


More information about the anaconda-patches mailing list