[PATCH] Switch to libtimezonemap for the timezone map.

Vratislav Podzimek vpodzime at redhat.com
Fri Nov 15 08:11:04 UTC 2013


On Thu, 2013-11-14 at 13:41 -0500, David Shea wrote:
> Remove all of our TimezoneMap widget code and paraphernalia in favor of
> it being somebody else's problem.
First of all, thanks a lot for working on this! A really great step in
the right direction.

I have just two comments:
1) We probably need 'Requires: libtimezonemap', I'm afraid rpmbuild
cannot find it out from our Python imports. Or can it? If yes, we could
drop libxklavier and libgnomekbd requires.

2) Could you please have a look at commits
16685955504af2563930340400c66e04b6e21cd1 and
4a53beafb8a1a4264844d98445d385b5cd4cd9ea and make sure those things are
covered somehow? I'm not saying that the solutions introduced with those
commits are the right ones, but we need to cover those cases.

Thanks again!

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list