[PATCH] Fix some pylint problems in network.py.

Chris Lumens clumens at redhat.com
Thu Nov 14 14:56:20 UTC 2013


---
 pyanaconda/network.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pyanaconda/network.py b/pyanaconda/network.py
index 41b4a28..2e353c5 100644
--- a/pyanaconda/network.py
+++ b/pyanaconda/network.py
@@ -506,14 +506,14 @@ def add_connection_for_ksdata(networkdata, devname):
         values.append(['connection', 'id', devname, 's'])
         values.append(['team', 'interface-name', devname, 's'])
         values.append(['team', 'config', networkdata.teamconfig, 's'])
-        for i, (slave, cfg) in enumerate(networkdata.teamslaves):
+        for _i, (slave, cfg) in enumerate(networkdata.teamslaves):
 
             # assume ethernet, TODO: infiniband, wifi, vlan
             #slave_name = "%s slave %d" % (devname, i)
             slave_name = slave
 
             svalues = []
-            suuid =  str(uuid.uuid4())
+            suuid =  str(uuid4())
             svalues.append(['connection', 'uuid', suuid, 's'])
             svalues.append(['connection', 'id', slave_name, 's'])
             svalues.append(['connection', 'slave-type', 'team', 's'])
@@ -819,14 +819,14 @@ def get_team_slaves(master_specs):
         for settings in slave_settings:
             try:
                 cfg = settings["team-port"]["config"]
-            except KeyError as e:
+            except KeyError:
                 cfg = ""
             devname = settings["connection"].get("interface-name")
             #nm-c-e doesn't save device name
             # TODO: wifi, infiniband
             if not devname:
-                type = settings["connection"]["type"]
-                if type == "802-3-ethernet":
+                ty = settings["connection"]["type"]
+                if ty == "802-3-ethernet":
                     hwaddr = settings["802-3-ethernet"]["mac-address"]
                     hwaddr = ":".join("%02X" % b for b in hwaddr)
                     devname = nm.nm_hwaddr_to_device_name(hwaddr)
-- 
1.8.3.1



More information about the anaconda-patches mailing list