[master][v2] Speed up the AddLayouts dialog

Vratislav Podzimek vpodzime at redhat.com
Thu Nov 14 06:48:53 UTC 2013


On Wed, 2013-11-13 at 11:38 -0500, Chris Lumens wrote:
> > Vratislav Podzimek (3):
> >   Allow having unique thread names with given prefix
> >   Add function to map functions on items in the main thread
> >   Initialize the AddLayouts dialog in advance in the KeyboardSpoke
> > 
> >  pyanaconda/constants.py                    |  5 ++
> >  pyanaconda/threads.py                      | 19 +++++++
> >  pyanaconda/ui/gui/spokes/datetime_spoke.py |  7 +--
> >  pyanaconda/ui/gui/spokes/keyboard.py       | 50 ++++++++++++-----
> >  pyanaconda/ui/gui/utils.py                 | 88 +++++++++++++++++++++++++++++-
> >  pyanaconda/ui/tui/simpleline/base.py       |  8 +--
> >  6 files changed, 150 insertions(+), 27 deletions(-)
> 
> These look fine to me.
> 
> Incidentally, at one point I considered enforcing all Spoke initialize
> methods running in threads using the scheme we have now with
> _initialize.  I decided it wasn't really all that important to do
> everywhere, but I at least thought about it.
Yeah, that may be another step, but I don't think it would help much
because of GIL.

I guess these three are acceptable for f20-branch as well?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list