[PATCH 2/2] Initialize the AddLayouts dialog in advance in the KeyboardSpoke

Vratislav Podzimek vpodzime at redhat.com
Wed Nov 13 07:00:50 UTC 2013


On Tue, 2013-11-12 at 10:52 -0500, Chris Lumens wrote:
> >  pyanaconda/constants.py              |  2 ++
> >  pyanaconda/ui/gui/spokes/keyboard.py | 51 +++++++++++++++++++++++++++---------
> >  2 files changed, 40 insertions(+), 13 deletions(-)
> > 
> > diff --git a/pyanaconda/constants.py b/pyanaconda/constants.py
> > index 48bc142..9416126 100644
> > --- a/pyanaconda/constants.py
> > +++ b/pyanaconda/constants.py
> > @@ -109,6 +109,8 @@ THREAD_DATE_TIME = "AnaDateTimeThread"
> >  THREAD_TIME_INIT = "AnaTimeInitThread"
> >  THREAD_XKL_WRAPPER_INIT = "AnaXklWrapperInitThread"
> >  THREAD_REFRESH_BASE_REPO = "AnaBaseRepoRefreshThread"
> > +THREAD_KEYBOARD_INIT = "AnaKeyboardThrad"
> 
> You've got a typo in the constant value there.
> 
> > diff --git a/pyanaconda/ui/gui/spokes/keyboard.py b/pyanaconda/ui/gui/spokes/keyboard.py
> > index 0952c8f..3a47f0b 100644
> > --- a/pyanaconda/ui/gui/spokes/keyboard.py
> > +++ b/pyanaconda/ui/gui/spokes/keyboard.py
> > @@ -25,12 +25,15 @@ from gi.repository import Gkbd, Gdk, Gtk
> >  from pyanaconda.ui.gui import GUIObject
> >  from pyanaconda.ui.gui.spokes import NormalSpoke
> >  from pyanaconda.ui.gui.categories.localization import LocalizationCategory
> > -from pyanaconda.ui.gui.utils import enlightbox, gtk_call_once, escape_markup
> > +from pyanaconda.ui.gui.utils import enlightbox, gtk_call_once, escape_markup, gtk_batch_map
> >  from pyanaconda import keyboard
> >  from pyanaconda import flags
> >  from pyanaconda.i18n import _, N_, CN_
> > -from pyanaconda.constants import DEFAULT_KEYBOARD
> > +from pyanaconda.constants import DEFAULT_KEYBOARD, THREAD_KEYBOARD_INIT, THREAD_ADD_LAYOUTS_INIT
> > +from pyanaconda.ui.communication import hubQ
> > +from pyanaconda.threads import threadMgr, AnacondaThread
> >  
> > +import threading
> >  import locale as locale_mod
> >  
> >  import logging
> 
> I think your threading import must be leftover from some previous worxwk
> in this file, yeah?
Good catches, thanks! Fixed in version 2 of the patches.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list