[PATCH] Don't use OrderedDict.

Chris Lumens clumens at redhat.com
Tue Nov 12 20:54:01 UTC 2013


> For _typeAsStr
> Maybe it would be better to have a strategy that went through all the items in self.typeMap.
> If it found more than one match it would break the tie in some appropriate way and return the correct one.

Well, currently the only strings that resolve to the same value are
"plain" and "partition", and that was a mistake.  I'd like to not
introduce another situation like that in the future, so I don't want to
deal with tie breaking.

> You could avoid the overload in F20 and the possibility that a buggy overload of _typeAsStr would
> return None even if the lookup value was in typeMap.values().

However, point taken about overloading.  Following up with another
patch.

- Chris


More information about the anaconda-patches mailing list