[PATCH pykickstart rhel7-branch?] Add support for network team devices (#1003591)
Radek Vykydal
rvykydal at redhat.com
Tue Nov 12 13:28:33 UTC 2013
On 11/06/2013 03:06 PM, Vratislav Podzimek wrote:
> On Wed, 2013-11-06 at 11:02 +0100, Radek Vykydal wrote:
>> + if len(parts) % 2:
> I think 'if len(parts) % 2 == 1' would be nicer.
Okay.
>> + if not parts[-1]:
>> + parts = parts[:-1]
>> + else:
>> + parts.append('')
>> + it = iter(parts)
>> + for devs, cfg in zip(it,it):
>> + devs = devs.strip(',').split(',')
>> + for d in devs[:-1]:
>> + teamslaves.append((d, ''))
>> + teamslaves.append((devs[-1], cfg))
> And this whole block processing the parts deserves a comment on what's
> going on maybe with some examples of values/parts.
>
Sending v2 of the patch.
More information about the anaconda-patches
mailing list