[PATCH rhel7-branch 3/5] network: support for adding team devices (#1003591)

Brian C. Lane bcl at redhat.com
Fri Nov 8 02:03:55 UTC 2013


On Wed, Nov 06, 2013 at 11:02:17AM +0100, Radek Vykydal wrote:
>          if dev_type in (NetworkManager.DeviceType.ETHERNET,
> +                        NetworkManager.DeviceType.TEAM,
>                          NetworkManager.DeviceType.BOND,
>                          NetworkManager.DeviceType.VLAN):

Looks like this could be a constant list like WIRED_DEVICES or something
like that so it doesn't need to be maintained in so many places.

> +        if dev_type in [NetworkManager.DeviceType.ETHERNET,
> +                        NetworkManager.DeviceType.BOND,
> +                        NetworkManager.DeviceType.VLAN,
> +                        NetworkManager.DeviceType.TEAM]:


> +        if dev_type in [NetworkManager.DeviceType.BOND,
> +                        NetworkManager.DeviceType.TEAM]:


> +        elif dev_type in [NetworkManager.DeviceType.BOND,
> +                          NetworkManager.DeviceType.TEAM]:

You used a [] instead of () in these 3 places when you use () everywhere
else.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list