[master][PATCH] Clear placeholder text when user searches lang in welcome (#946869)

Vratislav Podzimek vpodzime at redhat.com
Fri May 31 07:32:43 UTC 2013


On Thu, 2013-05-30 at 15:39 -0400, Samantha N. Bueno wrote:
> Relatively minor change; users have to manually delete the "Type
> here to search" string on the welcome screen if they do in fact want
> to search. This patch automatically clears that text out of the way
> when a user clicks the search field to begin typing.
> ---
>  pyanaconda/ui/gui/spokes/welcome.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/welcome.py b/pyanaconda/ui/gui/spokes/welcome.py
> index 812f809..7511a39 100644
> --- a/pyanaconda/ui/gui/spokes/welcome.py
> +++ b/pyanaconda/ui/gui/spokes/welcome.py
> @@ -329,7 +329,7 @@ class WelcomeLanguageSpoke(StandaloneSpoke):
>  
>      def on_clear_icon_clicked(self, entry, icon_pos, event):
>          if icon_pos == Gtk.EntryIconPosition.SECONDARY:
> -            entry.set_text(entry.get_placeholder_text())
> +            entry.set_text("")
>  
>      def on_entry_changed(self, *args):
>          self._languageStoreFilter.refilter()
ACK, the old behaviour is really awkward.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list