[PATCH 3/3] Wait for enough entropy when creating LUKS format

Chris Lumens clumens at redhat.com
Tue May 28 15:02:47 UTC 2013


> > 3. it would be nice if there were some abstraction of the callback
> >    handling in the DeviceAction classes
> Yeah, I agree with that. But I'm not sure there is any nice way how to
> do it. I was thinking about all actions calling their "pre" and "post"
> callbacks with names derived from their class names, but that would be a
> hack, I think. Any better suggestions? Maybe adding some _pre_callback
> and _post_callback class attributes holding the names of the callbacks
> to the actions? 

Do you envision adding a bunch more callbacks later?  Do you envison
that other consumers of blivet will want different sets of callbacks?
You could perhaps do a base class that defines callback methods, then a
subclass for your specific callbacks, then instantiate that.

- Chris


More information about the anaconda-patches mailing list