[PATCH] First check connecting, then connected state (#952801)

Vratislav Podzimek vpodzime at redhat.com
Mon May 27 12:42:16 UTC 2013


On Mon, 2013-05-27 at 14:33 +0200, Radek Vykydal wrote:
> Prevent a race when NM becomes connected between the two checks.
> ---
>  anaconda | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/anaconda b/anaconda
> index ac90d72..6d5c3f6 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -480,7 +480,7 @@ def setupDisplay(anaconda, opts, addon_paths=None):
>          flags.vncquestion = False
>  
>      # disable VNC question if we don't have network
> -    if not nm_is_connected() and not nm_is_connecting():
> +    if not nm_is_connecting() and not nm_is_connected():
>          stdoutLog.warning("Not asking for VNC because we don't have a network")
>          flags.vncquestion = False
>  
ACK, nice catch!

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list