[PATCH 3/3] Wait for enough entropy when creating LUKS format

David Lehman dlehman at redhat.com
Fri May 24 17:20:32 UTC 2013


On Fri, 2013-05-24 at 19:01 +0200, Vratislav Podzimek wrote:
> Also invoke the callback for such event (if any).
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>

Good idea. The blivet set looks good in general, but I have a few
comments:

1. MINIMAL_ENTROPY should go into devicelibs.crypto instead of
   formats.luks
2. consider moving get_current_entropy into devicelibs.crypto
3. it would be nice if there were some abstraction of the callback
   handling in the DeviceAction classes




More information about the anaconda-patches mailing list