[PATCH] Fix software selection in text UI.
Vratislav Podzimek
vpodzime at redhat.com
Wed May 22 08:23:31 UTC 2013
On Tue, 2013-05-21 at 21:49 -0400, Samantha N. Bueno wrote:
> There were a couple of major problems with this:
> -- selection was not getting applied and minimal install always
> applied during installation
> -- the way I handled threading in this spoke initially made things
> a bit screwy, causing the occasional traceback
>
> These amendments should make things behave much better now.
> ---
> pyanaconda/ui/tui/spokes/software.py | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/pyanaconda/ui/tui/spokes/software.py b/pyanaconda/ui/tui/spokes/software.py
> index b6912b9..63ca145 100644
> --- a/pyanaconda/ui/tui/spokes/software.py
> +++ b/pyanaconda/ui/tui/spokes/software.py
> @@ -37,13 +37,14 @@ class SoftwareSpoke(NormalTUISpoke):
> title = _("Software selection")
> category = "software"
>
> + # default to first selection (Gnome) in list of environments
> + _selection = 0
> +
> def __init__(self, app, data, storage, payload, instclass):
> NormalTUISpoke.__init__(self, app, data, storage, payload, instclass)
> self._ready = False
> self.errors = []
> self._tx_id = None
> - # default to first selection (Gnome) in list of environments
> - self._selection = 0
> self.environment = None
I don't understand this change. Why the _selection should be a class
attribute instead of instance attribute? Are there multiple intance of
it in the installation? Otherwise this looks good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list