[PATCH 1/3] When handling hidden devices in getDeviceBy*, don't use +=.

David Lehman dlehman at redhat.com
Tue May 21 21:42:59 UTC 2013


These all look okay except please drop the second hunk from patch 3 as
it merits a commit of its own, which I'm happy to do.

Dave

On Tue, 2013-05-21 at 15:26 -0400, Chris Lumens wrote:
> > diff --git a/blivet/devicetree.py b/blivet/devicetree.py
> > index 691f1b2..d32f09e 100644
> > --- a/blivet/devicetree.py
> > +++ b/blivet/devicetree.py
> > @@ -1914,9 +1914,10 @@ class DeviceTree(object):
> >              return None
> >  
> >          found = None
> > -        devices = self._devices
> >          if hidden:
> > -            devices += self._hidden
> > +            devices = self._devices + self._hidden
> > +        else:
> > +            devices += self._devices
> 
> Missed one here.  I'll fix it locally before pushing.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list