[PATCH 4/4] Add ability for users to specify an installation source repo in text UI.

Samantha N. Bueno sbueno+anaconda at redhat.com
Fri May 17 22:14:34 UTC 2013


On Fri, May 17, 2013 at 01:31:44PM -0400, Chris Lumens wrote:
> >  pyanaconda/ui/tui/spokes/source.py | 205 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 205 insertions(+)
> >  create mode 100644 pyanaconda/ui/tui/spokes/source.py
> 
> Remember to add this file to po/POTFILES.in, too.

Yes. Thank you for reminding (and about software.py); I would have
completely forgotten otherwise.
 
> > +    _protocols = ("Closest mirror", "http://", "https://", "ftp://")
> 
> You should mark the first one for translation, which means you'll then
> need to make some other changes to do comparisons correctly (translated
> against translated, or not against not).
>
> > +    edit_fields = [
> > +        Entry("Repo URL", "url", re.compile(".*$"), True)
> > +        ]
> 
> Likewise here.

Hm, I do agree I need to translate those two strings, but I'm not making
any string comparisons. Unless there is something I am missing? (It _is_
Friday evening, so that's very possible.)

Samantha


More information about the anaconda-patches mailing list