[PATCH 1/4] Make the beta warning in the upper right large.

Vratislav Podzimek vpodzime at redhat.com
Tue May 14 08:57:26 UTC 2013


On Mon, 2013-05-13 at 15:22 -0400, Chris Lumens wrote:
> This makes it the same size as the distribution text, which is what we
> had in the mockups.
> ---
>  widgets/src/BaseWindow.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/widgets/src/BaseWindow.c b/widgets/src/BaseWindow.c
> index d587d6e..c21eeca 100644
> --- a/widgets/src/BaseWindow.c
> +++ b/widgets/src/BaseWindow.c
> @@ -654,9 +654,9 @@ static void format_beta_label (AnacondaBaseWindow *window, const char *markup) {
>      gchar *escaped;
>      PangoAttrList *attrs;
>  
> -    /* define attributes -- medium size, bold weight and red text color */
> +    /* define attributes -- large size, bold weight and red text color */
>      attrs = pango_attr_list_new();
> -    pango_attr_list_insert(attrs, pango_attr_scale_new(PANGO_SCALE_MEDIUM));
> +    pango_attr_list_insert(attrs, pango_attr_scale_new(PANGO_SCALE_LARGE));
>      pango_attr_list_insert(attrs, pango_attr_weight_new(PANGO_WEIGHT_BOLD));
>      pango_attr_list_insert(attrs, pango_attr_foreground_new(0xfdfd, 0x1010, 0x1010));
>  
> @@ -669,6 +669,3 @@ static void format_beta_label (AnacondaBaseWindow *window, const char *markup) {
>      pango_attr_list_unref(attrs);
>      g_free(escaped);
>  }
> -
> -
> -
The size we have now was suggested by Máirín in a mockup [1] dealing
with making space for the layout indicator. I must say I like the
smaller size, but that's just a matter of opinion. As long as it still
fits into the header and doesn't cause it overflow the underlaying
gradient pixmap, I'm okay with this change.

[1]
http://linuxgrrl.com/fedora-ux/Projects/Anaconda/Sketches/Layout-Switching/taller-header_layout-position.png

The other patches look good to me as well.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list