[PATCH] Fix non-default language being hidden in welcome spoke

Vratislav Podzimek vpodzime at redhat.com
Thu May 9 20:24:08 UTC 2013


On Tue, 2013-05-07 at 10:49 -0400, Chris Lumens wrote:
> > Currently if Geolocation supplies a language other than the default,
> > it is correctly added to the top of the list in welcome spoke, but it
> > is outside of the viewport and thus not visible.
> > Using scroll_to_cell with use_align=True and row_align=0.5 should fix this.
> > Also, _selectLanguage has been modified to correctly use the filter
> > data model every time (previously it was sometimes using the treeview
> > data model directly and sometimes the filter).
> 
> Can you show me a picture of how things will look after this patch is
> applied?  I don't think I can get geolocation to give me a different
> language here.
For the czech language it looks like that:
http://vpodzime.fedorapeople.org/geoip_czech.png (without the patch)
http://vpodzime.fedorapeople.org/geoip_czech_with_patch.png (with the
patch)

The problem is a Gtk bug in scrolling the TreeView. I believe it should
show the whole row if it is asked to scroll to a row with it being
aligned to the center (row_aling=0.5) of the view and the row is the
first row in the store.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list