[PATCH] Add support for the realm command

Stef Walter stefw at redhat.com
Wed May 8 19:54:34 UTC 2013


On 08.05.2013 21:22, Chris Lumens wrote:
>> I think it is not necessary to have a Data object for the realm command.
>> It doesn't care about the order of the commands and runs everything in
>> the right order. It could even be:
>>
>> realm join --one-time-password=ThePassword --permit=all domain.example.com
>>
>> But the multiple-line syntax matches the manual realmd utility
>> invocation in a better way.
> 
> It's just completely different from how all other kickstart commands are
> processed, and if there's not a really good reason why it needs to be
> that way, it shouldn't.  I don't want to have a third style of things to
> have to remember and debug.
> 
> It also breaks the current assumption that each line maps to one piece
> of kickstart data, like all other commands do.  I don't know that I am
> relying on that anywhere, but it seems like a pretty handy assumption to
> have in the future.

If I recall correctly, the initial advice you had given was to make the
kickstart commands closely mirror the 'realm' command line command if
possible. Which is the case here. So this would have been an interesting
observation to have last year when these patches were posted.

Secondly the multiple lines can be independent of one another, and could
easily be implemented that way. In the same way that multiple repo,
user, or many other commands make sense when specified multiple times.

But it any case, if this at all increases the hope of getting this
finally merged, we can just drop the permit/deny stuff from kickstart in
this initial Fedora 19 version.

The default behavior of realmd is to respect domain login policy, and
the 'realm permit' stuff is just a handy tool on top of that. So let's
just drop it this point, since we barely have any time remaining to get
this in and tested.

Vratislav are you okay with dropping those commands, and only having
'join' for now?

Chris, with that change are you okay to have this merged?

Cheers,

Stef



More information about the anaconda-patches mailing list