[PATCH] Use systemd-localed for writing out xorg conf file (#958714)

Brian C. Lane bcl at redhat.com
Mon May 6 19:23:16 UTC 2013


On Mon, May 06, 2013 at 06:02:59PM +0200, Vratislav Podzimek wrote:
> Also use its file to write out configuration to the target system instead of our
> own file nobody reads. The systemd-localed's configuration file is read by Gnome
> and hopefully the other desktop environments as well.
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> ---
>  pyanaconda/keyboard.py | 245 ++++++++++++++++++++++++++++++-------------------
>  1 file changed, 153 insertions(+), 92 deletions(-)

> -    def set_and_convert_keymap(self, keymap):
> +    @property
> +    def keymap(self):
> +        keymap = dbus_get_property_safe_sync(LOCALED_SERVICE,
> +                                             LOCALED_OBJECT_PATH,
> +                                             LOCALED_IFACE,
> +                                             "VConsoleKeymap",
> +                                             self._connection)
> +

Are these various dbus_ calls guaranteed to return what's expected? If
not I'd like to see some defaults returned instead of generating a
traceback when they fail.

Other than that these look ok to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130506/df819fcb/attachment.sig>


More information about the anaconda-patches mailing list